apache / cordova-plugin-file-transfer

Apache Cordova File Transfer Plugin
https://cordova.apache.org/
Apache License 2.0
598 stars 885 forks source link

CB-12809: Google Play Blocker: Unsafe SSL TrustManager Defined #187

Closed macdonst closed 7 years ago

macdonst commented 7 years ago

Platforms affected

Android

What does this PR do?

It removes the trustAllHosts parameter from the Android FileTransfer code. Google will start blocking apps from the PlayStore that include unsafe implementations of the TrustManager.

What testing has been done on this change?

I've run a number of successful manual download tests after the change where the parameters are:

download(uri, fileURL, win, fail, false, options);
download(uri, fileURL, win, fail, true, options);
download(uri, fileURL, win, fail, options);
download(uri, fileURL, win, fail);

I ran the automatic test coverage and before my changes 25 tests failed and 2 tests were pending. After my changes 25 tests failed and 2 tests were pending.

Checklist

filmaj commented 7 years ago

I think we also want to remove the stuff from the README around how trustAllHosts is supported on Android.