CB-13294 Remove cordova-plugin-compat

kelvindart commented 6 years ago

Platforms affected

cordova-android@6.3.0

What does this PR do?

Removes the dependency on cordova-plugin-compat, and includes checks for min platform version.

What testing has been done on this change?

Testing 1:

Add local plugin to project containing cordova-android@6.3.0
Verify plugin installs, and app runs.

Testing 2:

Add local plugin to project containing cordova-android@6.2.3
Verify plugin does not install.
Console log as follows:

Plugin doesn't support this project's cordova-android version. cordova-android: 6.2.3, failed version requirement: >=6.3.0
Skipping 'cordova-plugin-file-transfer' for android

This is desirable - this change stops the plugin being installed on <cordova-android@6.3.0

Checklist

[x] Reported an issue in the JIRA database
[x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[ ] Added automated test coverage as appropriate for this change.

stevengill commented 6 years ago

Actually, this one removes file for some reason. Not compat. Compat doesn't exist here. I'm going to revert this commit

kelvindart commented 6 years ago

Shoot - so it does. I'll update it later tonight @stevengill. Not sure what I was thinking at the time...

apache / cordova-plugin-file-transfer