search

apache / cordova-plugin-file-transfer

Apache Cordova File Transfer Plugin
https://cordova.apache.org/
Apache License 2.0
598 stars 885 forks source link

change dependency version to file ^6.0.0 #195

Closed kaynz closed 6 years ago

oleksiy-nesterov commented 6 years ago

I am also waiting for this changes... PhoneGap Build can't build an app without this stuff.

davidgv88 commented 6 years ago

+1! Please merge!

macdonst commented 6 years ago

Merged but it might be a bit before a new release is out as we did a plugin release recently. As well this plugin is deprecated. Folks should start spending time replacing this plugin with XHR2 which should be available everywhere now.

kaynz commented 6 years ago

@macdonst The main problem in migrating to XHR2 is that it's not that easy to replace this plugin. The migration guide is incomplete:

https://cordova.apache.org/blog/2017/10/18/from-filetransfer-to-xhr2.html

TL;DR Standards are great and all, but what do you actually have to copy-paste to replace the previous FileTransfer examples? We have you covered:

Here's a replacement for FileTransfer's "Download a Binary File" example:

It's not a replacement at all. Old FileTransfer is saving the binary on the filesystem, where it survives a restart of the application. With the replacement code it will only be in the memory.

In my opinion, it would make more sense to replace relevant native code in this plugin with the corresponding XHR2 functions and keep this plugin up.