CB-12551: (android) Patch Security Provider to support TLS 1.2 - Githubissues

apache / cordova-plugin-file-transfer

Apache Cordova File Transfer Plugin

https://cordova.apache.org/

Apache License 2.0

596 stars 888 forks source link

CB-12551: (android) Patch Security Provider to support TLS 1.2 #197

Closed davidofwatkins closed 3 years ago

davidofwatkins commented 6 years ago

Platforms affected

Android 4.4 and below (API level 16-20)

What does this PR do?

Adds support for newer versions of TLS (v1.2) to older versions of Android (API level 16+) by patching the Security Provider with ProviderInstaller as per the documentation here: https://developer.android.com/training/articles/security-gms-provider.html

What testing has been done on this change?

I've only been able to test Android 4.4.x, but this should work on Android API levels 16+.

Checklist

[x] Reported an issue in the JIRA database
- Issue already exists: https://issues.apache.org/jira/browse/CB-12551
[x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[ ] Added automated test coverage as appropriate for this change.
- N/A

almas commented 6 years ago

I need this one. Please merge it.

davidofwatkins commented 6 years ago

@almas Thanks for the review! Feedback is addressed. Please let me know if you spot anything else :)

macdonst commented 6 years ago

@davidofwatkins sorry, one more comment I forgot earlier.

davidofwatkins commented 6 years ago

@macdonst Done, feedback addressed 👍 Thanks!

schotime commented 5 years ago

Is this going to get merged? We need it too. Thx.

janpio commented 5 years ago

Not as long as there are failing tests probably. @davidofwatkins could you rebase on master? Might fix the test failures.

janpio commented 5 years ago

I just submitted a fix to master, if you rebase on that your tests might pass (or at least fail less).

Neustradamus commented 4 years ago

Any news on it?

breautek commented 4 years ago

Any news on it?

This plugin is deprecated and no longer maintained.

See the readme for more info.

Neustradamus commented 4 years ago

@breautek: Thanks for your reply!

How replace it?

breautek commented 4 years ago

@breautek: Thanks for your reply!

How replace it?

Further reading can be found at https://cordova.apache.org/blog/2017/10/18/from-filetransfer-to-xhr2.html

timbru31 commented 3 years ago

Thanks a lot for your PR, however, support for Android API <22 has been dropped. It's a shame though that we haven't merged this back in 2018.