apache / cordova-plugin-file-transfer

Apache Cordova File Transfer Plugin
https://cordova.apache.org/
Apache License 2.0
595 stars 888 forks source link

fix(ios): headers are not being sent #284

Closed christiaan closed 3 years ago

christiaan commented 3 years ago

Platforms affected

iOS

Motivation and Context

The call to evaluateJavaScript is not blocking resulting in the headers being set on the request after it is already sent.

fixes #285

Description

Both the android and windows native code do not set the user-agent header. The user can still set the user-agent header by sending it from javascript.

Testing

I've changed these lines in our application because our FileTransfer uses a Authorization header that was not being sent anymore. After this change the request succeeds again.

Checklist

christiaan commented 3 years ago

@timbru31 is there anything I can do to move this forward?

timbru31 commented 3 years ago

Not really, I haven't found any time to test this yet. I'll try to do so over the weekend.

FD-DEV-IT commented 3 years ago

When will version 2.0.0 be completed?

timbru31 commented 3 years ago

"when it's done" - we do not give ETAs

joergHX277 commented 3 years ago

@timbru31 Hi Tim, it would be amazing if you could fix the issue below sometime soon. I would appreciate that a lot. Best Jörg

fix(ios): re-implement user agent overwrite #268 File upload breaking with Error code - 3 When updated from v1.7.2-dev to 2.0.0-dev #285

HarelM commented 3 years ago

Thanks! @timbru31