search

apache / cordova-plugin-file

Apache Cordova File Plugin
https://cordova.apache.org/
Apache License 2.0
741 stars 762 forks source link

Remove Microsoft's copyright notice from type definition file #401

Open kputh opened 4 years ago

kputh commented 4 years ago

Bug Report

Problem

The start of your TypeScript type definitions file contains a copyright notice claiming that it belongs to Microsoft:

// Type definitions for Apache Cordova File System plugin
// Project: https://github.com/apache/cordova-plugin-file
// Definitions by: Microsoft Open Technologies Inc <http://msopentech.com>
// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped
//
// Copyright (c) Microsoft Open Technologies, Inc.
// Licensed under the MIT license.

I suspect this is a copy-and-paste-mistake. You should correct it. You may also want to remove the outdated link to the DefinitelyTyped repo.

breautek commented 3 years ago

What's the problem here? License is in tact, and the code is licensed under MIT. Removing the copyright notice would be violating the license.

timbru31 commented 3 years ago

I’ll search the commits later, but indeed Microsoft originally authored those files. They were split from DefinetlyTyped to the actual software projects.

breautek commented 2 years ago

@purplecabbage Are you able to provide insight on this issue regarding code licensed/owned by a third-party?