fix(android): hasWritePermission for SDK 33 - Githubissues

apache / cordova-plugin-file

Apache Cordova File Plugin

https://cordova.apache.org/

Apache License 2.0

740 stars 757 forks source link

fix(android): hasWritePermission for SDK 33 #608

Closed erisu closed 7 months ago

erisu commented 7 months ago

Platforms affected

android

Motivation and Context

rebase, fix, and simplify changes from #581

Closes #581

Description

This PR performed following changes against #581:

Rebased against current main branch
Reverted previous changes to getWritePermission but applied suggestion to simplify. the condition check and to add extra accidental calls, even though the method would never be called in that scenario.
Simplifed hasWritePermission logic
Added comment suggestion to hasWritePermission

Testing

build test

Checklist

[ ] I've run the tests to see all new and existing tests pass
[ ] I added automated test coverage as appropriate for this change
[ ] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[ ] I've updated the documentation if necessary