apache / cordova-plugin-inappbrowser

Apache Cordova InAppBrowser Plugin
https://cordova.apache.org/
Apache License 2.0
1.11k stars 2.14k forks source link

Android: add try catch around dialog.dismiss() to prevent crashes #1018

Open jgruenberger opened 8 months ago

jgruenberger commented 8 months ago

Platforms affected

many different Android platforms out in the field

Motivation and Context

Resolves https://github.com/apache/cordova-plugin-inappbrowser/issues/470 Resolves https://github.com/apache/cordova-plugin-inappbrowser/issues/893 Resolves https://github.com/apache/cordova-plugin-inappbrowser/issues/1007 Resolves https://github.com/apache/cordova-plugin-inappbrowser/issues/384

Description

just adds a try catch block

Testing

We tested the change out in the field in a productive environment on 100+ different Android devices

Checklist

jgruenberger commented 8 months ago

We are getting app crashes from InAppBrowser on Crashlytics. This try catch claused resolved the issue.

Resolves #470 Resolves #893 Resolves #1007 Resolves #384

platov commented 1 month ago

@jgruenberger , will this PR be merged?

jgruenberger commented 1 month ago

Hi @platov,

i created the PR and hope the owner of the repo will merge it....

Best, Juergen