apache / cordova-plugin-inappbrowser

Apache Cordova InAppBrowser Plugin
https://cordova.apache.org/
Apache License 2.0
1.11k stars 2.14k forks source link

feat(android): Download event #1019

Closed breautek closed 8 months ago

breautek commented 8 months ago

Platforms affected

Android

Motivation and Context

Adds download event Rebase of version of https://github.com/apache/cordova-plugin-inappbrowser/pull/743 closes https://github.com/apache/cordova-plugin-inappbrowser/pull/743 closes #311

This PR fixes a merge conflict that the original PR had, as well as lint issues.

Description

Testing

Ran npm test Ran cordova-paramedic manually for android API 33. Ran a manual test and observed the download event coming through for download links.

Checklist

breautek commented 8 months ago

https://github.com/apache/cordova-plugin-inappbrowser/pull/1020 should fix any failing tests

breautek commented 8 months ago

Merging because this is simply a rebase of https://github.com/apache/cordova-plugin-inappbrowser/pull/743 which already has :+1: votes.

Chrome tests is failing is not related to this PR.