apache / cordova-plugin-inappbrowser

Apache Cordova InAppBrowser Plugin
https://cordova.apache.org/
Apache License 2.0
1.11k stars 2.14k forks source link

GH-1025 android: enable window.print() #1026

Open veelci opened 7 months ago

veelci commented 7 months ago

Platforms affected

Android

Motivation and Context

This change enables usage of window.print() on Android Partially implements #1025

Description

window.print is not implemented in Android's WebView. This change adds a print method to the cordova_iab JavaScript interface and overrides window.print to call the new print method.

Testing

1) Load up any Cordova application in an Android emulator. (I was using an emulated Pixel 7 Pro API 33) 2) Open up the Web Inspector JavaScript Console. 3) Run window.print() in the console. 4) The print preview should appear.

I attempted to run the cordova-mobile-spec tests, but encountered an error when running cordova-mobile-spec/createmobilespec/createmobilespec.js --android.

Error: Module cordova-lib installed in cordova-plugman is not npm-linked. I recommend you run "coho npm-link".
    at verifyNpmLinkOf (/Users/victorelci/Projects/cordova-test/cordova-mobile-spec/createmobilespec/createmobilespec.js:337:19)
    at Object.<anonymous> (/Users/victorelci/Projects/cordova-test/cordova-mobile-spec/createmobilespec/createmobilespec.js:358:9)

Checklist