feat(android): support Android 13 permission checks and requests - Githubissues

apache / cordova-plugin-media

Apache Cordova Media Plugin

https://cordova.apache.org/

Apache License 2.0

388 stars 767 forks source link

feat(android): support Android 13 permission checks and requests #382

Closed erisu closed 1 year ago

erisu commented 1 year ago

Platforms affected

android

Motivation and Context

Check for and request for permissions based on Android versions.

All Android versions will check for RECORD_AUDIO permission. If the permission is not missing (not granted), it will request for permission.

If Android SDK is less then 33, also check for WRITE_EXTERNAL_STORAGE. Request for the permission if missing.

Closes #380 Closes #374 Resolves #373

Description

refactored the promptForRecord method
removed excessive methods.

Testing

Created Cordova default project
Added plugin.
Tested recording functionality.
Tested playing the file that was created from the tested recording.
Confirmed that the temporary audio file name tmprecording-<KEY>.3gp was renamed to the specified filename.

Checklist

[x] I've run the tests to see all new and existing tests pass
[ ] I added automated test coverage as appropriate for this change
[x] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[ ] I've updated the documentation if necessary