search

apache / cordova-plugin-network-information

Apache Cordova Network Information Plugin
https://cordova.apache.org/
Apache License 2.0
464 stars 321 forks source link

fix NullPointerException #10

Closed dozer47528 closed 10 years ago

dozer47528 commented 10 years ago

crash when the info is null!

clelland commented 10 years ago

Hi Dozer,

I just found this as well -- I filed CB-6907 and fixed it yesterday (diff) (with almost exactly your fix :) )

Feel free to close this PR (And thanks for letting us know!)

dozer47528 commented 10 years ago

ok~

mariuspena commented 10 years ago

newbie here. I stumbled upon this error too. and happily found your fix. but I do not know how I can add this fix to my application's plugin. how to update the plugin with this fix ?

dozer47528 commented 10 years ago

@ceetah ,@clelland has commited it 8 days ago. You can pull the the new code from master.

ghost commented 10 years ago

sorry to ask but as that modif been "pushed" to cordova plugin repo? I just did a 

cordova plugin add org.apache.cordova.network-information

and I can't see the change in src/android/NetworkManager.java

clelland commented 10 years ago

No, it hasn't been pushed to the plugin repository. That will go out with the next plugin release. (Hopefully next week or the following, but I haven't heard of any plans to start that yet.)

ghost commented 10 years ago

OK thanks, I'll keep an eye out

jonathanrdelgado commented 10 years ago

+1 for bump

clelland commented 10 years ago

If you want to use this right now, you can install from github directly:

cordova plugin add https://github.com/apache/cordova-plugin-network-information.git

You don't technically need to wait for an official release if you just want this bug fix.

jonathanrdelgado commented 10 years ago

@clelland Thanks for that! Forgot about that functionality.