apache / cordova-plugin-network-information

Apache Cordova Network Information Plugin

https://cordova.apache.org/

Apache License 2.0

466 stars 322 forks source link

5G detection #125

Open ath0mas opened 3 years ago

ath0mas commented 3 years ago

Feature Request

Motivation Behind Feature

5G connectivity starts to be available on modern Android and iOS devices: since Android 11 and iOS 14/iPhone 12.

Feature Description

Detect 5G network and return 5g, from new value CELL_5G: '5g' to be added in Connection.js exports.

suggested API call for Android: https://developer.android.com/about/versions/11/features/5g#detection
TBD for other platforms

Alternatives or Workarounds

Don't know.

timbru31 commented 3 years ago

PR's welcome!

paulieo10 commented 3 years ago

Has there been any progress with this issue? I'd say being able to detect 5g is quite important. Does anyone know how the plugin behaves a the moment when a device is connected to 5g? Will it return UNKNOWN?

ZumelzuR commented 3 years ago

Has there been any progress with this issue? I'd say being able to detect 5g is quite important. Does anyone know how the plugin behaves a the moment when a device is connected to 5g? Will it return UNKNOWN?

I will do a PR with the improvements for 5g. I already tested with android but I still some time for ios.

ZumelzuR commented 3 years ago

https://github.com/apache/cordova-plugin-network-information/pull/130

cels commented 2 years ago

Is there anything new on this problem? The PR is open for almost a year :thinking:

ZumelzuR commented 2 years ago

Sorry was impossible for me to do the fixes they required for the MR. I did it today so hope they approve :D

cels commented 2 years ago

Thanks a lot!

cels commented 2 years ago

Anything new here? Is there a plan when this will be merged?

mdivya-symplr commented 2 years ago

@ZumelzuR Any plan for this code merge? or Are there any alternative to this?

breautek commented 2 years ago

@ZumelzuR Any plan for this code merge? or Are there any alternative to this?

He doesn't have write access to the repository, only Apache members can merge it in.

Looking at the PR it looks like it's marked as a breaking change, so it won't be merged in until we prepare the main branch as a major release. Right now it's prepared as a patch release.

Additionally it only has 1 approved review, and usually we like to see at least 2 approved reviews from Apache members. Others are also welcome to review/test the PR.

ZumelzuR commented 2 years ago

I dont know how to fix the ios12 test fail, if someone can lead me on this I could try to fix what is missing to be approved. Anyway for the moment feel free to use my fork https://github.com/ZumelzuR/cordova-plugin-network-information

BigBalli commented 1 year ago

Happy to help but the logs for this run have expired and are no longer available.

ZumelzuR commented 1 year ago

Happy to help but the logs for this run have expired and are no longer available.

Same here, how we can run this again?