search

apache / cordova-plugin-network-information

Apache Cordova Network Information Plugin
https://cordova.apache.org/
Apache License 2.0
464 stars 321 forks source link

[CB-7301] Adding NetworkManager::getType support for NetworkInfo.getTypeName() returning "CELLULAR" #16

Closed neojato closed 9 years ago

neojato commented 10 years ago

Added support for Android L (API 20) network information "TypeName" response of "CELLULAR"

jsoref commented 10 years ago

@neojato please see: http://wiki.apache.org/cordova/ContributorWorkflow (ICLA) http://wiki.apache.org/cordova/IssueWorkflow (file a bug in jira; include bug id and meaningful description of change in commit message)

the filename NetworkManager.java isn't important,

Adding NetworkManager::getType support for NetworkInfo.getTypeName() returning "CELLULAR" is.

neojato commented 10 years ago

@jsoref - Thanks for the links. I wasn't aware of those steps being that I came to this repo from PhoneGap's direct reference to it.

I've completed a majority of the steps and awaiting confirmation on the rest. I went ahead and created the jira case (https://issues.apache.org/jira/browse/CB-7301) with a meaningful description for this issue.

Since I've already created the pull request for this issue, how would you advise this moving forward? Another commit? Changing the title for the pull request to include a more meaningful description? Including the case id in this title?

Thanks in advance.

jsoref commented 10 years ago

Please feel free to change the summary of the PR. Please commit --amend / rebase -i (and squash/fold commits) including the jira id/etc in the first line. Then push -f the same branch to your github repo, github will do the rest.

neojato commented 10 years ago

@jsoref - I believe I have everything in order now, let me know if I've missed anything. I also just received an email that acknowledges receipt of my ICLA. Thanks.

zakrn commented 10 years ago

Sounds complicated lol On Aug 13, 2014 2:19 PM, "neojato" notifications@github.com wrote:

@jsoref https://github.com/jsoref - Thanks for the links. I wasn't aware of those steps being that I came to this repo from PhoneGap's direct reference to it.

I've completed a majority of the steps and awaiting confirmation on the rest. I went ahead and created the jira case ( https://issues.apache.org/jira/browse/CB-7301) with a meaningful description for this issue.

Since I've already created the pull request for this issue, how would you advise this moving forward? Another commit? Changing the title for the pull request to include a more meaningful description? Including the case id in this title?

Thanks in advance.

— Reply to this email directly or view it on GitHub https://github.com/apache/cordova-plugin-network-information/pull/16#issuecomment-52096890 .

neojato commented 10 years ago

@jsoref, it appears @infil00p duplicated my fix into the source on Sept 22 (https://github.com/apache/cordova-plugin-network-information/commit/37c0e3ff75f512b769b85a666f9a875e017de78d) over a month after I filed this pull request. I guess it's fixed now... :-\