Closed AllenConquest closed 8 years ago
Let there be tests
Cordova CI Build has completed successfully.
Dashboard - http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information/2/
Results
Is there any way we can push the results back thru git hub's regular hooks? These emails are excessive.
LGTM. These fixes are also in Apple's code as well: https://developer.apple.com/library/ios/samplecode/Reachability/Listings/Reachability_Reachability_m.html#//apple_ref/doc/uid/DTS40007324-Reachability_Reachability_m-DontLinkElementID_9
Note: we should update Reachability as well, there are some IPv6 stuff in the latest revision, or it points to better IPv6 support inherent. Not sure if we have the latest but better to be safe: https://developer.apple.com/library/ios/samplecode/Reachability/History/History.html#//apple_ref/doc/uid/DTS40007324-RevisionHistory-DontLinkElementID_1
When you perform an Analyze using Xcode 7, two places are identified as potential memory leaks. These should never happen, but the additional code will safely remove these warnings and tidy up if ever the situation did arise.