apache / cordova-plugin-network-information

Apache Cordova Network Information Plugin
https://cordova.apache.org/
Apache License 2.0
464 stars 321 forks source link

fixed two potential memory leaks when doing Analyze on iOS 9 #41

Closed AllenConquest closed 8 years ago

AllenConquest commented 8 years ago

When you perform an Analyze using Xcode 7, two places are identified as potential memory leaks. These should never happen, but the additional code will safely remove these warnings and tidy up if ever the situation did arise.

sarangan12 commented 8 years ago

Let there be tests

cordova-qa commented 8 years ago

Cordova CI Build has completed successfully.

Dashboard - http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-network-information/2/

Results

  1. Windows 8.1 Store - Console Output - Test Results - Device Logs
  2. Windows 10 Store - Console Output - Test Results - Device Logs
  3. Windows 8.1 Phone - Console Output - Test Results - Device Logs
  4. iOS - Console Output - Test Results - Build Artifacts
  5. Android Mac - Console Output - Test Results - Build Artifacts
  6. Android Windows - Console Output - Test Results - Device Logs
purplecabbage commented 8 years ago

Is there any way we can push the results back thru git hub's regular hooks? These emails are excessive.

shazron commented 8 years ago

LGTM. These fixes are also in Apple's code as well: https://developer.apple.com/library/ios/samplecode/Reachability/Listings/Reachability_Reachability_m.html#//apple_ref/doc/uid/DTS40007324-Reachability_Reachability_m-DontLinkElementID_9

shazron commented 8 years ago

Note: we should update Reachability as well, there are some IPv6 stuff in the latest revision, or it points to better IPv6 support inherent. Not sure if we have the latest but better to be safe: https://developer.apple.com/library/ios/samplecode/Reachability/History/History.html#//apple_ref/doc/uid/DTS40007324-RevisionHistory-DontLinkElementID_1