CB-12751: (ios) Fix connection type when airplane mode is on - Githubissues

apache / cordova-plugin-network-information

Apache Cordova Network Information Plugin

https://cordova.apache.org/

Apache License 2.0

464 stars 321 forks source link

CB-12751: (ios) Fix connection type when airplane mode is on #54

Closed cjpearson closed 7 years ago

cjpearson commented 7 years ago

Platforms affected

iOS

What does this PR do?

Reachability does not work properly when using Wifi then turning on Airplane mode.

What testing has been done on this change?

Tested on iOS 8-10.

Checklist

[x] Reported an issue in the JIRA database
[x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[ ] Added automated test coverage as appropriate for this change.

cordova-qa commented 7 years ago

Cordova CI Build has completed successfully.

Commit - Link Dashboard - Link

24 tests run, 0 skipped, 0 failed.

kylemellander commented 7 years ago

Just as a note and I don't seem to have permissions to post to jira, it seems that this error is happening on android as well

am commented 7 years ago

Amazed that someone took the effor to fix this and this is still here... Could someone take a look into this?

janpio commented 7 years ago

@am Can you test the changes, confirm that they work as expected and report back here? Tests at https://github.com/apache/cordova-plugin-network-information/blob/master/tests/tests.js might need some work for this to be covered as well.