fix: support ios 16.4 - Githubissues

apache / cordova-plugin-screen-orientation

Apache Cordova Screen Orientation Plugin

https://cordova.apache.org/

Apache License 2.0

219 stars 228 forks source link

fix: support ios 16.4 #118

Closed Zhliyun closed 1 year ago

Zhliyun commented 1 year ago

Platforms affected

iOS 16.4

Motivation and Context

iOS 16.4 supports screen.orientation, causing the plugin to not work properly

Description

The Safari screen.orientation api cannot be extended, causing the original method conflict to fail

Testing

Checklist

[x] I've run the tests to see all new and existing tests pass
[x] I added automated test coverage as appropriate for this change
[x] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[ ] I've updated the documentation if necessary

timbru31 commented 1 year ago

Thanks a lot for your PR, however this is indeed a duplicate of #116 which was raised before this PR. :)