chore: drop Node.js v4 support - Githubissues

apache / cordova-plugin-statusbar

Apache Cordova Status Bar Plugin

https://cordova.apache.org/

Apache License 2.0

617 stars 480 forks source link

chore: drop Node.js v4 support #124

Closed timbru31 closed 5 years ago

timbru31 commented 5 years ago

This is a BREAKING CHANGE.

Platforms affected

n/a - development

What does this PR do?

Drop Node.js v4 support and bumps the CI images to Node.js v6

What testing has been done on this change?

TravisCI and Appveyor test results.

Checklist

[ ] Reported an issue in the JIRA database
[ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[ ] Added automated test coverage as appropriate for this change.

timbru31 commented 5 years ago

Part of https://github.com/apache/cordova/issues/72

timbru31 commented 5 years ago

I've updates this PR:

AppVeyor does tests against Node.js v6, 8 and 10 LTS with x86 and x64 versions now
TravisCI config has been simplified - the nvm comment has been added

timbru31 commented 5 years ago

This PR should be ready to review. If it's fine I'm going to update other plugins in the same scheme, too.

janpio commented 5 years ago

I think the $TRAVIS_NODE_VERSION in the travis overview is bad enough to go back to explicitly specifying the node version, what do you think?

timbru31 commented 5 years ago

Yeah it does not look that nice in the dashboard, that's true. I'm going to change it back

janpio commented 5 years ago

Awesome.

Do we maybe want to extend the CI configuration a bit more before you take on the work to distribute the new configuration to all plugins? (In a new PR of course) We should really test newer and other relevant versions of iOS and Android.

timbru31 commented 5 years ago

@janpio Done!

Do we maybe want to extend the CI configuration a bit more before you take on the work to distribute the new configuration to all plugins? (In a new PR of course) We should really test newer and other relevant versions of iOS and Android.

Sounds like a plan 👍

timbru31 commented 5 years ago

Compare https://travis-ci.org/apache/cordova-plugin-statusbar/builds/495179874 with the master branch: https://travis-ci.org/apache/cordova-plugin-statusbar/builds/491750452 - 10 jobs run each 👍

janpio commented 5 years ago

❤️