apache / cordova-plugin-statusbar

Apache Cordova Status Bar Plugin
https://cordova.apache.org/
Apache License 2.0
618 stars 480 forks source link

fix(browser): Remove invalid proxy function #230

Closed jcesarmobile closed 1 year ago

jcesarmobile commented 1 year ago

Platforms affected

browser

Motivation and Context

Should be styleLightContent instead of styleLightContect, but that's already there, so remove the wrong one

Description

Testing

Checklist

erisu commented 1 year ago

I don't know if this API was ever released in a previous version or only in the main branch, but is this removal considered as a major breaking change?

Eventhough it is only removing the incorrectly spelled API, and the API with the correct spelling eixsts, this was a public API?

jcesarmobile commented 1 year ago

I don’t think it’s breaking, it’s been there forever, but it’s a typo and has never existed on the js API, so I don’t think people would be using it just for browser, This proxy is just so the plugin in browser platform appears as implemented and can be “used”, but all methods will just log that the plugin is not supported and call the success callback.