Closed aegliv closed 6 years ago
This is awesome, I hope it gets merged soon :+1:
I tested this feature on Motorola devices and it looks good, but this isn't the case when testing on Samsung and Sony Xperia devices, the statusbar doesn't look transparent and it's more like a dark gradient on the top.
This isn't the case when using apps like Google Play, they have a correct transparent statusbar whilst this not.
Pushing this PR from oblivion: Maybe Google Play uses AppCompat and that's why it has a Material-style translucent status bar? I'm not sure if this is possible, just wondering.
Anyway, the option in @MrARC screenshot seems totally acceptable in Android 4.x devices, as I guess is the default behavior.
P.S. It would be great if this feature could be mapped like this for Android, as it already exists in iOS:
<preference name="StatusBarStyle" value="blacktranslucent" />
Sorry, i forgot to say that the device was running Android 5.1, which is weird because Lollipop has support for translucent statusbar.
@MrARC My bad, I thought it was 4.x because the home button is not a circle. The code in the PR just reverses the two flags set by the plugin. Maybe is related to OEMs changing this when they apply their own personalization to the UI?
Cordova CI Build has completed successfully.
Commit - Link Dashboard - Link
Builder Name | Console Output | Test Report | Device Logs |
---|---|---|---|
Windows 8.1 Store | Link | Link | Link |
Windows 10 Store | Link | Link | Link |
Windows 8.1 Phone | Link | Link | Link |
iOS | Link | Link | Link |
Android Mac | Link | Link | Link |
Android Windows | Link | Link | Link |
+1 for blacktranslucent For me transparent statusbar is only working with this pull. :/ Android 5.0.1.
Please merge.
Will it be merged?
Great Work, @aegliv
Please merge this.
Good job and +1, I would love to see this PR merged as well, especially that ekuwang / cordova-plugin-statusbar , is having a few bugs. Any ETA
Hmm, still having an issue the translucent status bar is visible only when in fullScreen mode :-( which is coming with it s own lot of issue. Anyway to make it transparent with a webOverlay without having to set the mode to immersive ?
@MrARC & @anymos:
It works for us on multiple Nexus, LG and Samsung devices without Immersive.
If it doesn't work for you, it is probably related to other settings made prior or after the flags are set with styleAndroidTransparent()
.
Please try to debug the flag settings in StatusBar.java
This pull isn't going anywhere. Is anyone - who is seeing a gradient instead of a translucent bar - willing to debug this in order to move it forward?
👍
If nobody is able to replicate the gradient status bar in 5.x+ and debug, let's move on and merge this already. It's ridiculous, it has been 9 months already!
Any reason it hasn't been already merged? I mean, for a Ionic development this is almost REQUIRED. The current bar looks completly bad when a modal or something involving an opaque background layer is displayed:
What do you need or what are you waiting for to modernize this component?
The probability of merging pull requests are higher when they follow the Pull Request template of the project: https://github.com/apache/cordova-plugin-statusbar/blob/master/.github/PULL_REQUEST_TEMPLATE.md This one, for example, needs an issue at the official issue tracker.
Also: No conflicts with current master
and no uncommented problems in the comments of the PR helps.
This looks incredibly similar to #78, if this is the case, I'm definitely going to be closing this one in favour of that PR that merges more cleanly.
Replaces the need for following plugin: ekuwang / cordova-plugin-statusbar