search

apache / cordova-plugin-vibration

Apache Cordova Vibration Plugin
https://cordova.apache.org/
Apache License 2.0
127 stars 131 forks source link

CB-7970 Add cordova-plugin-vibration support for Windows Phone 8.1 #25

Closed daserge closed 9 years ago

daserge commented 10 years ago

Added Windows Phone 8.1 support Updated documentation

JIRA issue

This change is because wp platform does not support vibrateWithPattern actually

purplecabbage commented 9 years ago

There are a few issues here. Strictly saying support is added for Windows Phone 8.1 will confuse users who probably don't know the major underlying differences between what we call a cordova-wp8 app and a cordova-windows ( universal with target of wp8.1 )

We need to be extremely clear about this so users understand.

I would preface the device supports document with : windows ( univeral w/ target --phone ) or something.

I would also like to let this stew a bit, so I can restructure some of the way the windows-universal solution adds c# and c++ code. I find it unwieldy to keep adding projects to the solution, and would like to have a better architecture for this. I will be doing a feature branch to prove the concept.

daserge commented 9 years ago

Hello Jesse,

Thanks for the review, I have updated the docs. By restructuring do you mean using csproj instead of winmd component?

sgrebnov commented 9 years ago

Rebased, tested, merged