search

apache / cordova-plugin-vibration

Apache Cordova Vibration Plugin
https://cordova.apache.org/
Apache License 2.0
127 stars 129 forks source link

No automated tests #70

Open janpio opened 5 years ago

janpio commented 5 years ago

The tests in tests/tests.js are all manual tests, on CI nothing is executed as a result.

timbru31 commented 5 years ago

Are you sure? Travis is running something on SauceLabs: https://github.com/apache/cordova-plugin-vibration/blob/master/.travis.yml#L83-L86, but who is the user snay? https://github.com/apache/cordova-plugin-vibration/blob/master/.travis.yml#L7

janpio commented 5 years ago

snay is a Cordova committer. All SauceLabs tests are run in that account.

Here is a recent build: https://travis-ci.org/apache/cordova-plugin-vibration/jobs/463895815

Almost at the bottom:

cordova-paramedic: connecting to app
cordova-paramedic: waiting for test results
Spec started
Executed 0 of 0 specs SUCCESS in 0.001 sec.
cordova-paramedic: tests have been completed
cordova-paramedic: Tests finished

Easy to pass that way ;)

timbru31 commented 5 years ago

Ah now I see - 0 specs.