Closed timbru31 closed 5 years ago
Uh, this should get an issue in https://github.com/apache/cordova as a collection for all plugins. Then all the PRs can link to that issue, we can make sure all plugins were taken care of etc.
Is this already based on something we did for another Cordova repo? (these CI configs should be pretty much copy/paste to all similar repos in the best case)
We had https://github.com/apache/cordova/issues/5, but just for tooling and platforms
Yeah, go ahead and create a new one. It's worth to centralize these things, otherwise someone will have to go through all repos in the future and make sure the all use the same config.
There we go: https://github.com/apache/cordova/issues/72
Great. See my PR comments on https://github.com/apache/cordova-plugin-statusbar/pull/124/files before you continue please.
@janpio - ready for review now
CI passes again, see https://github.com/apache/cordova/issues/72#issuecomment-486007935 - I've used the same matrix as in https://github.com/apache/cordova-paramedic.
If paramedic is finished I can continue to update the other plugins. /cc @erisu
We have a passing state at paramedic, so now we'll see what happens with the first plugins. https://github.com/apache/cordova-plugin-inappbrowser/pull/465 is the other first try to adapt the configuration from there.
I think you missed the local test for your adaptation here. But all the tests passing is nice.
I think you missed the local test for your adaptation here.
Indeed
Obsolete with #80 - whoops, AppVeyor is still relevant.
Part of apache/cordova#72
Platforms affected
n/a - development
Motivation and Context
Drops EOL Node.js 4 from CI config. BREAKING CHANGE! :)
Description
see above.
Testing
TravisCI and Appveyor test results.
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)