apache / cordova-plugin-wkwebview-engine

[DEPRECATED] Apache Cordova wkwebview engine plugin
Apache License 2.0
612 stars 358 forks source link

Added ios platform version restrictions #158

Closed breautek closed 4 years ago

breautek commented 4 years ago

Platforms affected

ios

Motivation and Context

This plugin is not supported on cordova-ios@6, therefore this PR adds a restraint for cordova-ios < 6

Closes https://github.com/apache/cordova-plugin-wkwebview-engine/issues/157

Description

Changed package.json and plugin.xml to restrict this plugin on cordova-ios@6.

Testing

I ran npm test, but I could not run the native tests cause I don't have easy access to mac hardware. I'm relying on CI builds for native tests, and they have passed successfully.

I've tested using a project with the plugin installed, adding cordova platform add ios@5.1.1 works as expected, cordova platform add ios@6 produces:

Plugin doesn't support this project's cordova-ios version. cordova-ios: 6.0.0, failed version requirement: >=4.0.0 <6.0.0
Skipping 'cordova-plugin-wkwebview-engine' for ios

As expected.

Checklist