unnecessary to add 'frameworks' to source files

[athibaud]

adding static libs to source files will add these to the build section. which is unnecessary and results in a warning in xcode:

warning: no rule to process file 'path/to/lib.a' of type archive.ar for architecture __arch

[agrieve]

@athibaud - was this fixed? Or is this still something that we should add in? @imhotep - do you know?

[athibaud]

@agrieve from a quick glance to the code it doesn't seem like it was fixed. can't check more thoroughly right now.

[agrieve]

@athibaud Getting back to this - would like to write a test for it. How can I reproduce the error?

[imhotep]

@agrieve I might be mistaken but I don't think this would produce any errors. It's just for organizational esthetics and only applies to static libraries. @shazron might be able to confirm.

[athibaud]

@imhotep indeed this does not produce an error just a warning though i would argue fixing this is not just for organisational aesthetics but correctness. minor anyhow.

@agrieve as mentioned in the PR simply adding a static library to the dependencies should cause the warning, something like:

<platform name="iOS">
  ...
  <source-file src="path/to/static/lib.a" />
  ...
</platform>

[shazron]

Correct - no error, but not correct nonetheless. It was a minor issue during the time. Ideally static libs should not be considered "source files" but have another mechanism to be added to the project (since <framework> does not copy the static lib to the project, we need <source-file> to do this)

[agrieve]

Okay, sounds good! I've created a JIRA issue for it: https://issues.apache.org/jira/browse/CB-6025

And have merged it in.

Please close the pull request.