search

apache / cordova-plugman

Apache Cordova Plugman
https://cordova.apache.org/
Apache License 2.0
399 stars 151 forks source link

[CB-4372] Fixed "Plugman fails when fetching local plugins with space in path" #15

Closed jamesjhedley closed 11 years ago

jamesjhedley commented 11 years ago

URI module was converting spaces to %20 which made them invalid.

jeffheifetz commented 11 years ago

Please add a unit test so this doesn't brake in the future.

jamesjhedley commented 11 years ago

@jeffheifetz Added a unit test and a comment as requested.

jeffheifetz commented 11 years ago

Looks good to me

jamesjhedley commented 11 years ago

@bryanhiggins can we merge this please.

bryanhiggins commented 11 years ago

merged here: https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;a=commit;h=2a8b9add0f7fb2d98a172cba404203772e65d951

@jkeshavarzi please close this