[CB-4715] Parse URL parameters 'subdir' and 'ref' when fetching plugins

apache / cordova-plugman

Apache Cordova Plugman

https://cordova.apache.org/

Apache License 2.0

399 stars 151 forks source link

[CB-4715] Parse URL parameters 'subdir' and 'ref' when fetching plugins #30

Closed jbondc closed 10 years ago

jbondc commented 10 years ago

Both the npm hash links and query style url's would be supported.

To test: cordova plugin add https://github.com/jbondc/cordova-labs.git?subdir=cordova-deps-test

agrieve commented 10 years ago

Looks like this was addressed in a slightly different way in: https://issues.apache.org/jira/browse/CB-4622

I don't think we should add query parameter-based options as well because query parameters are sent to the server and can actually change what git repo you end up hitting. This is the case for the ASF repos.

Does that sound okay?

Could you close this pull request?

agrieve commented 10 years ago

@jbondc Please close