search

apache / cordova-plugman

Apache Cordova Plugman
https://cordova.apache.org/
Apache License 2.0
399 stars 151 forks source link

[CB-4714] Allow forcefully removing a plugin from the command line #31

Closed jbondc closed 10 years ago

bshepherdson commented 10 years ago

LGTM, so long as you've tested this carefully. Dependencies-related logic is tricky, as I have learned the hard way. I thought the previous overhaul of this code I did was correct three times, but found bugs on further testing.

jbondc commented 10 years ago

I'll do some testing and write a spec test.

bshepherdson commented 10 years ago

Any update?

jbondc commented 10 years ago

I'm stuck on the cli tests (windows fails).

Ideally I'd like to rewrite: https://github.com/apache/cordova-plugman/blob/master/spec/uninstall.spec.js#L100

And add the test cases for -f etc... Looks all a bit cryptic to me right now.

agrieve commented 10 years ago

This is still not merged, right? Any progress updates?

agrieve commented 10 years ago

@jbondc Status of this?

jbondc commented 10 years ago

Just finished big refactoring patch around nopt, I'd say coming in 3.5

agrieve commented 10 years ago

Going to close this given the work that's gone on since. Open a new one to continue on.

jbondc commented 10 years ago

Ya will have a fix for it soon.

renandecarlo commented 9 years ago

This is very annoying when dealing with a variety of plugins and self linked resourceful libraries. They often conflict with plugin depencies.