search

apache / cordova-plugman

Apache Cordova Plugman
https://cordova.apache.org/
Apache License 2.0
400 stars 151 forks source link

PB-6160 adding plugin fails for Firefoxos. #61

Closed Steckelfisch closed 10 years ago

stevengill commented 10 years ago

merged in! Please close

jsoref commented 10 years ago

@Steckelfisch please note that the JIRA label should be "CB-6160" not "PB-6160" :(

designbyadrian commented 10 years ago

Will this fix the same issue with the CLI?

designbyadrian commented 10 years ago

No, I don’t.

I’m referring to xml_helpers undefined when trying to call cordova plugin add XXXX, and after that cordova prepare failrs to with same error.

Not using Plugman, though

/AvG

On 13 mar 2014, at 11:59, Gert-Jan Braas notifications@github.com wrote:

I think you refer to https://issues.apache.org/jira/browse/CB-5751, and the answer is no. The CLI issue is specific for Windows, I created a separate pull-request to add build.bat.

— Reply to this email directly or view it on GitHub.

designbyadrian commented 10 years ago

Though it seems to be related to

https://issues.apache.org/jira/browse/CB-6160

On 13 mar 2014, at 11:59, Gert-Jan Braas notifications@github.com wrote:

I think you refer to https://issues.apache.org/jira/browse/CB-5751, and the answer is no. The CLI issue is specific for Windows, I created a separate pull-request to add build.bat.

— Reply to this email directly or view it on GitHub.

Steckelfisch commented 10 years ago

I noticed, hence my comment retraction.

I had the same problem you describe. As I understand plugman (cordova-plugman) is used by 'cordova plugin ...' and that's how i got to the same error. ( i got hte error while adding firefoxos testing to cordova-plugman)

So then the answer should be yes, as I do not have the error anymore.

Steckelfisch commented 10 years ago

do you have a stack-trace?

designbyadrian commented 10 years ago

Is this sufficient?

>cordova plugin add org.apache.cordova.splashscreen Fetching plugin "org.apache.cordova.splashscreen" via plugin registry Installing org.apache.cordova.splashscreen (firefoxos) ReferenceError: xml_helpers is not defined at Object.module.exports.package_name (/usr/local/lib/node_modules/cordova/node_modules/plugman/src/platforms/firefoxos.js:25:26) at PlatformMunger.generate_plugin_config_munge (/usr/local/lib/node_modules/cordova/node_modules/plugman/src/util/config-changes.js:285:54) at PlatformMunger.add_plugin_changes (/usr/local/lib/node_modules/cordova/node_modules/plugman/src/util/config-changes.js:211:29) at /usr/local/lib/node_modules/cordova/node_modules/plugman/src/util/config-changes.js:368:14 at Array.forEach (native) at PlatformMunger_process [as process] (/usr/local/lib/node_modules/cordova/node_modules/plugman/src/util/config-changes.js:367:45) at Object.exports.process (/usr/local/lib/node_modules/cordova/node_modules/plugman/src/util/config-changes.js:77:12) at Object.handlePrepare (/usr/local/lib/node_modules/cordova/node_modules/plugman/src/prepare.js:74:20) at /usr/local/lib/node_modules/cordova/node_modules/plugman/src/install.js:420:33 at _fulfilled (/usr/local/lib/node_modules/cordova/node_modules/q/q.js:798:54)

Steckelfisch commented 10 years ago

yep. .../node_modules/plugman/src/...

so it's the same issue

designbyadrian commented 10 years ago

I don't want to turn this into a chat, but I honestly don't know where to follow Cordova updates.

Is there an ETA for the next Cordova update?

I guess I can update /usr/local/lib/node_modules/cordova/node_modules/plugman/src/platforms/firefoxos.js myself until then, but I'm afraid of breaking something else.

Steckelfisch commented 10 years ago

to late :-).

I don't know when it will be updated. So you have to fix it yourself, or install a previous version of plugman. I think 3.4.0-0.1.0 still works correct.