apache / cordova-windows

[DEPRECATED] Apache Cordova Windows
Apache License 2.0
203 stars 171 forks source link

Cordova platform add windows@^7.0.0 command not copying the node_modules #325

Closed aman2604 closed 5 years ago

aman2604 commented 5 years ago

Cordova platform add windows@^7.0.0 command not copying the node_modules into node_modules\cordova-windows\node_modules

Instead all the node_modules are present directly inside \node_modules.

Might be the side effect of https://github.com/apache/cordova-windows/pull/317

aman2604 commented 5 years ago

@review - @erisu

erisu commented 5 years ago

@aman2604 This is not a side effect of PR #317 and is the expected behavior.

Node modules are no longer bundled in any of the platforms including cordova-windows.

What PR #317 does is copies the node_modules folder only if it is present. Since there is no node_modules directory, it has nothing to copy. The use case where the node_module directory exists is from stand alone non-CLI usage.

For more information, you can check out these two tickets: