apache / cordova-windows

[DEPRECATED] Apache Cordova Windows
Apache License 2.0
203 stars 171 forks source link

base.js not copied when adding windows platform @7.0.0 #326

Closed holyhoehle closed 5 years ago

holyhoehle commented 5 years ago

Bug Report

Problem

What is expected to happen?

The Windows platform should be added without errors.

What does actually happen?

The following error is logged (twice): cp: no such file or directory: C:\Temp\test\node_modules\cordova-windows\node_modules\winjs\js\base.js

Information

If you create a new cordova project and then try to add the windows platform version 7.0.0 the following output is logged:

Using cordova-fetch for cordova-windows@7.0.0
Adding windows project...
Creating Cordova Windows Project:
        Path: platforms\windows
        Namespace: io.cordova.hellocordova
        Name: HelloCordova
cp: no such file or directory: C:\Temp\test\node_modules\cordova-windows\node_modules\winjs\js\base.js

cp: no such file or directory: C:\Temp\test\node_modules\cordova-windows\node_modules\winjs\js\base.js

Windows project created with cordova-windows@7.0.0
Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the project
Installing "cordova-plugin-whitelist" for windows
Adding cordova-plugin-whitelist to package.json
Saved plugin info for "cordova-plugin-whitelist" to config.xml
--save flag or autosave detected
Saving windows@~7.0.0 into config.xml file ...

It seems as if the paths to the base.js file are not resolved properly. They should be _C:\Temp\test\nodemodules\winjs\js\base.js instead of _C:\Temp\test\nodemodules\cordova-windows\node_modules\winjs\js\base.js

Command or Code

cordova create test
cd test
cordova platform add windows@7.0.0

Environment, Platform, Device

Windows 10 Enterprise Version 1809 Build 17763.379

Version information

Cordova 8.1.2 (cordova-lib@8.1.1)

Checklist

janpio commented 5 years ago

Can confirm the observed behavior:

E:\Projects\throwaway
λ cordova create cordovaWindows7Test
Creating a new cordova project.

E:\Projects\throwaway
λ cd cordovaWindows7Test\

E:\Projects\throwaway\cordovaWindows7Test  (helloworld@1.0.0)
λ cordova platform add windows@7.0.0
Using cordova-fetch for cordova-windows@7.0.0
Adding windows project...
Creating Cordova Windows Project:
        Path: platforms\windows
        Namespace: io.cordova.hellocordova
        Name: HelloCordova
cp: no such file or directory: E:\Projects\throwaway\cordovaWindows7Test\node_modules\cordova-windows\node_modules\winjs\js\base.js

cp: no such file or directory: E:\Projects\throwaway\cordovaWindows7Test\node_modules\cordova-windows\node_modules\winjs\js\base.js

Windows project created with cordova-windows@7.0.0
Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the project
Installing "cordova-plugin-whitelist" for windows
Adding cordova-plugin-whitelist to package.json
Saved plugin info for "cordova-plugin-whitelist" to config.xml
--save flag or autosave detected
Saving windows@~7.0.0 into config.xml file ...

E:\Projects\throwaway\cordovaWindows7Test  (helloworld@1.0.0)
λ
EmeryGuillaume commented 5 years ago

Hello @janpio, I've just upgraded my project to cordova-windows@7.0.0 and I can confirm the exact same behavior. The error is logged twice while adding the platform. At runtime, the application is missing WinJS.