apache / couchdb-docker

Semi-official Apache CouchDB Docker images
https://github.com/apache/couchdb-docker
Apache License 2.0
257 stars 133 forks source link

Add s390x support to CouchDB docker image #245

Closed kun-lu20 closed 1 year ago

kun-lu20 commented 1 year ago

Overview

Since the s390x .deb binary on debian:bullseye is released from v3.3.2 afterwards and all pre-requisites mentioned in https://github.com/apache/couchdb-docker/issues/67#issue-293689385 are available now, this PR aims to add s390x support to CouchDB docker image.

Testing recommendations

https://github.com/apache/couchdb-docker#how-to-use-this-image https://docs.couchdb.org/en/stable/intro/tour.html

I've built the multi-arch docker image on an Intel VM after applying the code change in this PR and verified the generated s390x image on a s390x VM. It worked fine.

GitHub issue number

https://github.com/apache/couchdb-docker/issues/67

Checklist

kun-lu20 commented 1 year ago

Hi @nickva ,

Could you please take a look at this PR as well? Thank you so much!

nickva commented 1 year ago

Thank you for your contribution, @kun-lu20!

kun-lu20 commented 1 year ago

Thanks @nickva !

kun-lu20 commented 1 year ago

Hi @nickva ,

Could you please update the following file as well, so that the docker official image of CouchDB v3.3.2+ can have s390x support?

https://github.com/docker-library/official-images/blob/bde595a716993f12b5bcd0476915b6bc0c17d3b4/library/couchdb#L10

Thank you so much!

nickva commented 1 year ago

@kun-lu20, sure thing, thanks for the reminder. I created a PR: https://github.com/docker-library/official-images/pull/14752

kun-lu20 commented 1 year ago

Thanks @nickva !