apache / couchdb-erlfdb

Erlang API for FoundationDB
https://www.foundationdb.org
Apache License 2.0
28 stars 20 forks source link

Refactor build scripts to remove binary blobs #25

Closed noahshaw11 closed 3 years ago

noahshaw11 commented 3 years ago

Currently couchdb-erlfdb includes binary blobs enc and rebar. We don't have any means to verify how these binaries were built. This is a security risk. This PR clones and builds these binaries when make is run.

wohali commented 3 years ago

Hey Noah, see my comment over on https://github.com/apache/couchdb-jiffy/pull/4 . This repo, at least, is canonically a part of CouchDB, so I'm not closing this PR.

wohali commented 3 years ago

@noahshaw11 ? It's OK to remove this one, isn't it?

noahshaw11 commented 3 years ago

@wohali Yes, feel free to. The removal of enc caused significant issues. Going to take a much different approach. Thank you!