search

apache / couchdb-erlfdb

Erlang API for FoundationDB
https://www.foundationdb.org
Apache License 2.0
28 stars 20 forks source link

rebar3 / Windows support / GH Action CI #29

Closed kocolosk closed 2 years ago

kocolosk commented 2 years ago

I wasn't sure if GH Actions could be developed in branches, but it sort of seems like they cannot. Here's a simple attempt to run unit tests on Pull Requests and every push to main.

kocolosk commented 2 years ago

Ah! Turns out they can -- and I have some issue to fix :)

wohali commented 2 years ago

@kocolosk FYI, doing it with GHA instead of Jenkins will put you in the global build queue for GHA for the ASF, which is rate limited across the board:

Average queue depth per repo @ ASF for 2021: https://cwiki.apache.org/confluence/download/attachments/191336468/image2021-11-1_14-33-54.png?version=1&modificationDate=1635773634000&api=v2

Number of ASF repos using GHA for 2021: https://cwiki.apache.org/confluence/download/attachments/191336468/image2021-11-1_14-28-47.png?version=1&modificationDate=1635773328000&api=v2

You are probably OK for now, but if the queue depths become a problem.... I know Jenkins stinks to use, but it's at least our dedicated hardware, and the pre-built Docker containers already support everything in main.

kocolosk commented 2 years ago

@wohali Yeah I saw those queue depths and was a bit surprised since my experience from the last few days has been that Actions are starting immediately. But clearly it's been an issue at times.

I'm totally fine using Jenkins, but I started down this GHA experiment because of Windows support. Do we have any view to adding a Windows executor to the CouchDB Jenkins setup?

wohali commented 2 years ago

not going to have time to look at this for a while - sorry about that. Don't let my lack of a review block this PR, and thanks for picking up the work on this Adam.

kocolosk commented 2 years ago

No worries Joan, I just knew Windows + CI are areas of interest and wanted to make sure you knew the work on this branch had settled down in case you had time to take a look.