Fully support FDB API version 630

kocolosk commented 2 years ago

It seems there are a handful of changes in API version 630 that we ought to be accounting for:

https://apple.github.io/foundationdb/api-version-upgrade-guide.html#api-version-630

Specifically:

The get_addresses_for_key function now returns strings that include the port in the address. Prior to API version 630, this required using the INCLUDE_PORT_IN_ADDRESS option, which has now been deprecated.
The ENABLE_SLOW_TASK_PROFILING network option has been replaced by ENABLE_RUN_LOOP_PROFILING and is now deprecated.
The FDBKeyValue struct’s key and value members have changed type from void* to uint8_t*.

kocolosk commented 2 years ago

As far as I can tell only the ENABLE_RUN_LOOP_PROFILING option requires any actual code changes; that's now been added in 0f3bee4. We ought to have a better story for warning about the use of deprecated options, but they're not causing any harm at the moment.

kocolosk commented 2 years ago

Turns out we also need to support get_estimated_range_size: https://github.com/apple/foundationdb/commit/69b572cc8

apache / couchdb-erlfdb

Fully support FDB API version 630 #38