apache / couchdb-erlfdb

Erlang API for FoundationDB
https://www.foundationdb.org
Apache License 2.0
28 stars 20 forks source link

Tests should guard against setting random keys which write to \xFF #46

Closed nickva closed 2 years ago

nickva commented 2 years ago

We need to fix a few cases like these:

https://github.com/apache/couchdb-erlfdb/blob/main/test/erlfdb_02_anon_fdbserver_test.erl#L34-L37

As they lead to spurious failures when the key is prefixed with \xFF. I added a gen function which does just that https://github.com/apache/couchdb-erlfdb/blob/main/test/erlfdb_03_transaction_options_test.erl#L100-L102 so we'd just have to re-use the pattern in other tests.