search

apache / couchdb-erlfdb

Erlang API for FoundationDB
https://www.foundationdb.org
Apache License 2.0
28 stars 20 forks source link

Deallocate future mutex in the future resource destructor #50

Closed nickva closed 2 years ago

nickva commented 2 years ago

Otherwise we end up leaking mutexes https://github.com/apache/couchdb-erlfdb/issues/49

kocolosk commented 2 years ago

Bah, we need to update CI for the foundationdb.org switch.

kocolosk commented 2 years ago

Seems like there's an issue with the 6.2.30 Windows install of FDB (the build is crashing when it tries to parse the output of fdbcli --version). I think we could merge without that flavor of the matrix passing this time.

nickva commented 2 years ago

Ah makes sense, @kocolosk, thanks for taking a look.

I had noticed the user reported an abort and core dump https://github.com/apache/couchdb-erlfdb/issues/49#issuecomment-1021525764 and wondering if we have another bug or I misunderstood how resource reference counting and destructors work.

nickva commented 2 years ago

It looks like the user double-checked and the issue doesn't happen any longer (it was a build / compile issue) before.

dch commented 2 years ago

Great sleuthing here. Can you push a git tag for this please? I’ll update downstream FreeBSD when that’s done

On Tue, 25 Jan 2022, at 21:48, Nick Vatamaniuc wrote:

Merged #50 https://github.com/apache/couchdb-erlfdb/pull/50 into main.

— Reply to this email directly, view it on GitHub https://github.com/apache/couchdb-erlfdb/pull/50#event-5952733451, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACFNUGTUXYPHJV4Z4MFIBDUX4EBRANCNFSM5MY4WSLA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- — Dave Cottlehuber @.*** Sent from my Couch

nickva commented 2 years ago

@dch good idea, will do

nickva commented 2 years ago

tagged https://github.com/apache/couchdb-erlfdb/releases/tag/v1.3.5

gave the "autogenerate release notes" button a try. seems to work well enough