apache / couchdb-fauxton

Fauxton is the new Web UI for CouchDB
https://github.com/apache/couchdb-fauxton
Apache License 2.0
373 stars 225 forks source link

Fix errors in Nightwatch tests #1450

Closed Antonio-Maranhao closed 1 month ago

Antonio-Maranhao commented 1 month ago

Overview

Fix syntax errors when calling Nightwatch execute() function.

Testing recommendations

Verify that errors like the one below are no longer printed:

>> Error
>>      Response 500 POST /session/00adc39b522f52a7247d46533b2f9bc4/execute/sync (19ms)
   {
     value: {
       error: 'javascript error',
       message: 'javascript error: Invalid left-hand side in assignment\n' +
         '  (Session info: chrome=125.0.6422.141)',
       stacktrace: ''
     }
  }

GitHub issue number

n/a

Related Pull Requests

n/a

Checklist

Antonio-Maranhao commented 1 month ago

Hi @big-r81, looks like your recent changes to .asf.yaml are preventing PRs from being merged. There are two issues: 1) checks are not getting triggered for PRs like this one from a fork 2) even then the checks run, they don't match the required names, like in https://github.com/apache/couchdb-fauxton/pull/1451

Because of 2, I don't have permission to merge a fix. Could you please look into addressing this?

big-r81 commented 1 month ago

@Antonio-Maranhao I am currently trying to solve the problem...

big-r81 commented 1 month ago

@Antonio-Maranhao Should be fixed now, but it seems you need to re-run your "personal" gh action ...

Antonio-Maranhao commented 1 month ago

Thanks for the quick action on this @big-r81. Much appreciated.

big-r81 commented 1 month ago

@Antonio-Maranhao Checks are working now and are run when opening a PR against main. Now you can choose wheter to merge this PR or #1451.