apache / couchdb-helm

Apache CouchDB Helm Chart
https://couchdb.apache.org/
Apache License 2.0
49 stars 64 forks source link

Add pdb #117

Closed bryopsida closed 1 year ago

bryopsida commented 1 year ago

What this PR does / why we need it:

Adds a optional PDB to make node drains/cordons safer

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.

willholley commented 1 year ago

thanks for the PR @bryopsida. It seems that CI is failing, though I'm not entirely sure why - it passes locally for me so is perhaps a timing issue.

bryopsida commented 1 year ago

thanks for the PR @bryopsida. It seems that CI is failing, though I'm not entirely sure why - it passes locally for me so is perhaps a timing issue.

I tested out a white space only change here: https://github.com/bryopsida/couchdb-helm/actions/runs/4986433003 and that worked so it seems isolated to this branch.

When I have some more time I'll try and isolate what's going on.

bryopsida commented 1 year ago

@willholley looks like I was missing a null check on podDisruptionBudget, I was counting on the default value being present but looks like that's not the case in CI.

I tested it here https://github.com/bryopsida/couchdb-helm/actions/runs/5032284491 and here https://github.com/bryopsida/couchdb-helm/actions/runs/5032313655 and it worked.