search

apache / couchdb-helm

Apache CouchDB Helm Chart
https://couchdb.apache.org/
Apache License 2.0
49 stars 64 forks source link

feat: allow configure persistentVolumeClaimRetentionPolicy #136

Closed ByJacob closed 6 months ago

ByJacob commented 7 months ago

What this PR does / why we need it:

Allow to specify a persistentVolumeClaimRetentionPolicy in both the primary and secondary StatefulSet.

Special notes for your reviewer:

This allows for automatic cleanup of PVCs after deletion, etc. An example use case of this is for highly dynamic test environments, where cleaning up the PVCs after deletion of the helm chart is preferred.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.

ByJacob commented 6 months ago

Thanks for the PR! Can you rebase on master? I'm happy to merge this (assuming tests pass), though it's probably worth adding a comment that this is a beta feature in Kubernetes so is generally unavailable. We may have to revisit this if/when this becomes GA.

done

ByJacob commented 6 months ago

thanks @ByJacob - can you increment the chart version?

done :)