apache / couchdb-helm

Apache CouchDB Helm Chart
https://couchdb.apache.org/
Apache License 2.0
49 stars 64 forks source link

Give the `Service` default port (5984) a name so that it is not ambiguous if `service.extraPorts` is used. #156

Closed samwho closed 5 months ago

samwho commented 5 months ago

What this PR does / why we need it:

Sorry about this @willholley, but I noticed when trying to update to 4.5.4 and use my new extraPorts values that if you try to have multiple ports on a Service in Kubernetes, all ports need a name (https://github.com/kubernetes/kubernetes/issues/36803). If there's just one port, this name property is optional. Sadly this renders service.extraPorts useless in 4.5.4, so for 4.5.5 I've given the default port a name.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.

samwho commented 5 months ago

Thank you so much for reviewing these PRs so quickly, we really appreciate it 🙏