Add configurable path - Githubissues

apache / couchdb-helm

Apache CouchDB Helm Chart

https://couchdb.apache.org/

Apache License 2.0

49 stars 64 forks source link

Add configurable path #6

Closed arjun-1 closed 5 years ago

arjun-1 commented 5 years ago

What this PR does / why we need it:

Makes the path in the ingress configurable, defaulting to '/'.

Which issue this PR fixes

fixes #4

Special notes for your reviewer:

Checklist

[x] Chart Version bumped
[x] e2e tests pass
[x] Variables are documented in the README.md
[x] Chart tgz added to /docs and index updated

arjun-1 commented 5 years ago

I'm trying to run make test, but it seems that the test hangs at: 1 chart(s) linted, no failures Installing chart 'couchdb => (version: "2.3.0", path: "couchdb")'... Not sure though whether something is misconfigured on my machine, or did something wrong in the PR...

willholley commented 5 years ago

@arjun-1 it may not be clear but you need to install https://github.com/kubernetes-sigs/kind to run the tests. Also please don't delete any old chart packages - running make publish should update the docs folder correctly.

arjun-1 commented 5 years ago

Alright, thanks for the help @willholley ;). Should be good to go.

willholley commented 5 years ago

thanks for the contribution @arjun-1 - looks great