apache / couchdb-helm

Apache CouchDB Helm Chart
https://couchdb.apache.org/
Apache License 2.0
49 stars 64 forks source link

Add CI via GitHub Actions #80

Closed colearendt closed 2 years ago

colearendt commented 2 years ago

What this PR does / why we need it:

Add CI:

Some open items to discuss here:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

(removed: NA)

willholley commented 2 years ago

Thanks for the PR @colearendt - it generally looks good to me. On the discussion points:

how do we do this in such a way that it does not affect your current setup? Should we create a gh-pages branch to maintain the "new" index.yaml on until you want to cut over the definition of GitHub pages? Will that affect anything?

I think this is right, and should be a safe change for existing users:

should we remove the "changed vs. all" components of the action?

If the change detection is reliable then I'm happy to go with linting changes only

are any of the dependencies concerning?

They all look well used/maintained, so no concerns from me.

we also have an action that we use to code-generate README.md (to keep documentation up to date with the values.yaml file) via helm-docs. Is this something that would be interesting to you?

Yes - that sounds helpful!

are there any arguments to linting and testing that would be helpful? i.e. --upgrade maybe?

I think testing with --upgrade makes sense as we do today. This has caught a few issues for us in the past.

colearendt commented 2 years ago

TIL about .asf.yaml! Nice!

I have made the discussed changes:

One last idea:

willholley commented 2 years ago

run lint-only changes on branches (still running all on main because there are never any changes otherwise. Testing/linting on main still seems desirable).

It seems like if we do this we should also require linear history (we can set in .asf.yaml)

wanted to make sure that push to main and pull_request is the right definition for triggers

That seems right to me.

+1