apache / couchdb-nano

Nano: The official Apache CouchDB library for Node.js
https://www.npmjs.com/package/nano
Apache License 2.0
651 stars 165 forks source link

Update types for nano.request #233

Closed jseminck closed 3 years ago

jseminck commented 3 years ago

Overview

I updated the type for the request function which currently looks incorrect. The request function is documented correctly in the readme though: https://github.com/apache/couchdb-nano#nanorequestopts-callback

A type for RequestOptions already existed so I re-used that.

Testing recommendations

I tested this change in my local development environment by changing the code in the node_modules folder.

GitHub issue number

I considered raising an issue first to question whether this change is needed or not, but as the change is so minor then I decided creating a PR was easier.

Checklist