Don't fail make clean if hex is not installed

apache / couchdb

Seamless multi-master syncing database with an intuitive HTTP/JSON API, designed for reliability

https://couchdb.apache.org/

Apache License 2.0

6.26k stars 1.03k forks source link

Don't fail make clean if hex is not installed #5250

Closed nickva closed 2 months ago

nickva commented 2 months ago

@mix clean --deps apparently requires hex to be installed. If it's not there, it stops and prompts the user to install it. If configure hasn't run yet, as in the case when building our deb package from the dist tarball, package build fails.

This was mitigated in couchdb-pkg by adding hex to /home/jenkins/.mix for CI images, but let's also handle it better in the Makefile.

Makefile.win already has || true added to it so no need to updated it.

jaydoane commented 2 months ago

Thanks for figuring out why this was failing and how to properly fix it Nick!

nickva commented 2 months ago

@jaydoane no problem at all. It was a tricky one as it was failing with dist tarball on my docker instance. I remember we tried to use the full CI build to validate this case and it passed there. But I think in the CI jenkins instance we have a mounted shared mix archive cache so it was finding the hex package but on my docker it couldn't.