apache / couchdb

Seamless multi-master syncing database with an intuitive HTTP/JSON API, designed for reliability
https://couchdb.apache.org/
Apache License 2.0
6.28k stars 1.03k forks source link

Do not crash the server on invalid js_engine setting #5329

Closed nickva closed 3 weeks ago

nickva commented 3 weeks ago

In the previous PR [1] Jessica had discovered that an invalid engine setting crashes the server. Initially I had thought we would be strict about it and just let it crash, but that seems a bit harsh for this. Especially if there is a large cluster and configuration is pushed to all nodes. It would crash the whole cluster.

Instead, since we have a default, stick with that. Especially now users can validate if a non-default js_engine is active from the welcome endpoint.

[1] https://github.com/apache/couchdb/pull/5327