apache / daffodil-sbt

Apache Daffodil SBT Plugin
https://daffodil.apache.org/
Apache License 2.0
1 stars 3 forks source link

Update scala-library to 2.12.20 #53

Closed scala-steward closed 1 month ago

scala-steward commented 1 month ago

About this PR

📦 Updates org.scala-lang:scala-library from 2.12.19 to 2.12.20

📜 GitHub Release Notes - Version Diff

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

🔍 Files still referring to the old version number The following files still refer to the old version number (2.12.19). You might want to review and update them manually. ``` src/main/scala/org/apache/daffodil/DaffodilPlugin.scala ```
⚙ Adjust future updates Add this to your `.scala-steward.conf` file to ignore future updates of this dependency: ``` updates.ignore = [ { groupId = "org.scala-lang", artifactId = "scala-library" } ] ``` Or, add this to slow down future updates of this dependency: ``` dependencyOverrides = [{ pullRequests = { frequency = "30 days" }, dependency = { groupId = "org.scala-lang", artifactId = "scala-library" } }] ```

labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:1

stevedlawrence commented 1 month ago

From the SBT Plugin Docs

  • sbt plugins must be compiled with Scala 2.12.x that sbt itself is compiled in. By NOT specifying scalaVersion, sbt will default to the Scala version suited for a plugin.
  • By default sbt plugin is compiled with whichever the sbt version you are using. Because sbt does NOT keep forward compatibility, that would typically require all of your plugin users to upgrade to the latest too. pluginCrossBuild / sbtVersion is an optional setting to compile your plugin against an older version of sbt, which allows the plugin users to choose from a range of sbt versions.

So we should probably shouldn't set scalaVersion at all. I think setting crossSbtVersion like we do now is sufficient.