Resolved Windows Lingering OE Server

apache / daffodil-vscode

Apache Daffodil™ Extension for Visual Studio Code

https://daffodil.apache.org/

Apache License 2.0

11 stars 19 forks source link

Resolved Windows Lingering OE Server #1006

Closed stricklandrbls closed 5 months ago

stricklandrbls commented 5 months ago

Pushed DataEditor object to VSCode context subscriptions stack.
Fixed sending of a serverStop request when given a predicate.

Closes #1005

stricklandrbls commented 5 months ago

@shanedell @rthomas320 Did you run yarn test with this PR to confirm the server shutdown? @scholarsmate noticed that the test will still leave the server lingering.

Also, did you test this PR by using the packaged .vsix file or through the Extension debug launch config?

shanedell commented 5 months ago

@stricklandrbls I had just pulled the code down and ran the test. But @scholarsmate is right there does seem the server is still lingering after yarn test I did notice this the first time I ran but maybe I wasn't fully synced to your changes.

stricklandrbls commented 5 months ago

@shanedell For just testing the PR though, did the OE server shutdown after exiting the VSCode window with a data editor panel open? Also, did you run it through the Extension launch config or by installing the .vsix file?

shanedell commented 5 months ago

@stricklandrbls Yeah when using it through UI and I stop the debug or even close the VSCode window the omega-edit server is being killed. Only when I run the tests is when the server is still running.