search

apache / daffodil-vscode

Apache Daffodil™ Extension for Visual Studio Code
https://daffodil.apache.org/
Apache License 2.0
11 stars 20 forks source link

Daffodil debugger server to use domain sockets and named FIFOs #639

Open scholarsmate opened 1 year ago

scholarsmate commented 1 year ago

Firewalls and other TCP services on the same ports have been and will continue to cause problems for users. If possible, add support for domain sockets and named FIFOs in a way that will be cross-platform.

scholarsmate commented 1 year ago

It appears that the debugger server already has support for domain sockets and named pipes (see: https://github.com/apache/daffodil-vscode/blob/main/src/adapter/extension.ts#L43). We need to verify that it works and document it. Also I think it's worth making it the default way that we connect to the server if it works.

arosien commented 1 year ago

I wonder if a different interface should be used: I believe 0.0.0.0 is used by default, but 127.0.0.1 might be less restricted by the OS?

In any case, we could allow finer-grained hostname/interface control in the config to test this.

arosien commented 1 year ago

Do folks actually have issues now that localhost is used by default (vs. 0.0.0.0)? cc: @scholarsmate @mbeckerle @stevedlawrence

arosien commented 1 year ago

Do folks actually have issues now that localhost is used by default (vs. 0.0.0.0)? cc: @scholarsmate @mbeckerle @stevedlawrence

Re-ping @scholarsmate @mbeckerle @stevedlawrence

stevedlawrence commented 1 year ago

Are you asking if it's okay to not switch to domain sockets/fifos because we use tcp localhost? I personally have no strong preference so seems fine to me. But I do agree with the main comment that it might be useful to avoid issues related to firewalls/unavailable ports, though probably not problem in most cases.