Closed scholarsmate closed 3 months ago
stricklandrbls
commented
3 months ago check that the CPU Load Average is now no being reported because it is not in tolerance.
Is that supposed to say "not being reported"? Running this PR as described but I don't see the CPULoadAverage from this section:
https://github.com/apache/daffodil-vscode/blob/4b09ed25b80d6c9f7cd1a811c0aa68871e1b6407/src/svelte/src/components/ServerMetrics/ServerMetrics.svelte#L133-L136
Screenshot Reference
scholarsmate
commented
3 months ago @stricklandrbls, that is the expected behavior. If a measurement is not in tolerance, it doesn't get reported at all. Not sure why the Windows JVM can't properly report the average CPU load, but if that ever does get repaired, then it will be properly reported in the metrics at that time without any changes to this code.
@rthomas320, perhaps that's happening because this branch needs to be rebased to incorporate any recent updates and fixes. If that's the case, I'll do a rebase and force push it.
scholarsmate
commented
3 months ago @rthomas320, the branch is currently up-to-date with main. Can you please try again? Be sure to run git clean -fdx before the build to make sure it's clean.
stricklandrbls
commented
3 months ago @scholarsmate I retested the PR with the main rebase and it still works as expected.
... If a measurement is not in tolerance, it doesn't get reported at all ...
I'm wondering if we should have a placeholder for this in the output instead of just omitting it entirely.
To test this, run the Data Editor from a Windows machine, hover over the green dot down where the Omega Edit status information is, and check that the CPU Load Average is now not being reported because it is not in tolerance.
Fixes CPU Load Average reports -1.0.0 in Windows.
closes #989